Permit specifying property tests as closures #62
Conversation
| } | ||
| }; | ||
|
|
||
| (move |($($parm:pat in $strategy:expr),+)| $body:block) => { |
| |(y in 0..100)| { | ||
| assert!(x != y); | ||
| } | ||
| }; |
There was a problem hiding this comment.
... add a test that ensures that it keeps working if we make changes :)
There was a problem hiding this comment.
Thanks, fixed. This one slipped my mind!
There was a problem hiding this comment.
Thanks for the contribution! I meant to look at this yesterday but was pretty out of it by the time it was submitted.
I do think it's worth bringing in. There's a couple simple changes I noted, but I can just do those after merging. If nothing unexpected comes up I think I can have this in tomorrow evening.
src/sugar.rs
Outdated
| @@ -674,6 +673,25 @@ macro_rules! proptest_helper { | |||
| (@_WRAPSTR ($a:pat, $($rest:pat),*)) => { | |||
| (stringify!($a), proptest_helper!(@_WRAPSTR ($($rest),*))) | |||
| }; | |||
| // build a property testing block that when executed, executes the full property test. | |||
| (@_BODY $config:ident ($($parm:pat in $strategy:expr),+) $body:block) => {{ | |||
There was a problem hiding this comment.
The code that sets the source file should probably be here so that it also applies to the new case.
There was a problem hiding this comment.
Done. I kept the .clone() in the calling macro to match how it behaved with clone_with_source_file().
src/sugar.rs
Outdated
|
|
||
| (|($($parm:pat in $strategy:expr),+)| $body:block) => { | ||
| || { | ||
| let config = $crate::test_runner::Config::default(); |
There was a problem hiding this comment.
We should check that the config doesn't have fork() enabled since that feature requires proptest having control over the top-level test function.
There was a problem hiding this comment.
Thanks!
Ended up checking for both fork and timeout features, even though one depends on another. Possibly worth to introduce a no_fork flag in config which takes precedence to make this clearer.
|
PS: before you release this; I'm working on a PR related to it :) |
|
This is released in 0.8.1. |
This change permits easily sharing things captured from the environment.
Consider a simple test framework like this: